🍒[clang][modules] Invalidate module cache when SDKSettings.json changes #10679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
llvm#139751) This PR adds the `%sdk/SDKSettings.json` file to the PCM input file table, so that the PCM gets invalidated when the file changes. This is necessary for availability checks to work correctly.
The input file section in module files only stored files loaded into the `SourceManager`. When rebuilding the module cache, include-trees also include other files, like the SDKSettings.json file. If we don't invalidate the module cache when that file changes, the corresponding include-trees won't agree with the primary TU include-tree on the file contents. This was fixed in llvm#139751 and this PR adds an include tree test. I intentionally suppress reporting of this new file in tests, so that I don't have go updating ~all of them. This file is getting reported by the scanning C API, so that the build system is given the ability to eventually act on this file being out-of-date. rdar://149868539
This fixes the Index/Store/handle-prebuilt-module.m test that started failing after llvm#139751.
jansvoboda11
force-pushed
the
jan_svoboda/release-6.2-sdk-settings-json
branch
from
57b1430 to
7bb8a75
Compare
|
@swift-ci please test |
akyrtzi
approved these changes
May 19, 2025
|
swiftlang/swift#81620 |
|
swiftlang/swift#81620 |
beccadax
added a commit
to swiftlang/swift
that referenced
this pull request
May 21, 2025
It is failing, probably due to swiftlang/llvm-project#10679. See rdar://151740686.
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
%sdk/SDKSettings.jsonfile to the PCM input file table, so that the PCM gets invalidated when the file changes. This is necessary for availability checks to work correctly and for the include-tree to be rebuilt so that its file list agrees with other include-trees (coming from the module cache or the primary TU).rdar://149868539